the-other-tim-brown commented on code in PR #13383: URL: https://github.com/apache/hudi/pull/13383#discussion_r2127199973
########## hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogBlockMetadataScanner.java: ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.table.log; + +import org.apache.hudi.avro.HoodieAvroReaderContext; +import org.apache.hudi.common.engine.HoodieReaderContext; +import org.apache.hudi.common.table.HoodieTableMetaClient; +import org.apache.hudi.common.table.timeline.HoodieInstant; +import org.apache.hudi.common.util.Option; + +import org.apache.avro.generic.IndexedRecord; + +import java.util.List; + +/** + * Scans a set of log files to extract metadata about the log blocks. It does not read the actual records. + */ +public class HoodieLogBlockMetadataScanner extends BaseHoodieLogRecordReader<IndexedRecord> { + + public HoodieLogBlockMetadataScanner(HoodieTableMetaClient metaClient, List<String> logFilePaths, int bufferSize, Option<InstantRange> instantRange) { + super(getReaderContext(metaClient), metaClient, metaClient.getStorage(), logFilePaths, false, bufferSize, instantRange, false, false, Option.empty(), Option.empty(), true, + null, false); + scanInternal(Option.empty(), true); + } + + private static HoodieReaderContext<IndexedRecord> getReaderContext(HoodieTableMetaClient metaClient) { + HoodieReaderContext<IndexedRecord> readerContext = new HoodieAvroReaderContext(metaClient.getStorage().getConf(), metaClient.getTableConfig(), Option.empty(), Option.empty()); + readerContext.setHasLogFiles(true); + readerContext.setHasBootstrapBaseFile(false); + readerContext.setLatestCommitTime(metaClient.getActiveTimeline().lastInstant().map(HoodieInstant::requestedTime).orElseThrow(() -> new IllegalStateException("No completed instant found"))); Review Comment: Updated this to take in the maxInstant value from the caller to better max the current usage -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
