nsivabalan commented on code in PR #13305:
URL: https://github.com/apache/hudi/pull/13305#discussion_r2125053316
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/WriteStatus.java:
##########
@@ -76,10 +78,15 @@ public class WriteStatus implements Serializable {
private final boolean trackSuccessRecords;
private final transient Random random;
- public WriteStatus(Boolean trackSuccessRecords, Double failureFraction) {
+ public WriteStatus(Boolean trackSuccessRecords, Double failureFraction,
Boolean isMetadataTable) {
Review Comment:
<img width="890" alt="image"
src="https://github.com/user-attachments/assets/9989d509-dd5e-4eb0-9129-8e92e1847360";
/>
So, the object values are already interpreted as "Boolean" class. and the
constructor args is derived as "Boolean"
<img width="1461" alt="image"
src="https://github.com/user-attachments/assets/62497045-e646-4f98-a907-573a0443a0a1";
/>
not sure if it can make fixes just for this. Only option I can think of is
to change any "Boolean" to primitive boolean while going via reflection
utils.loadClass().
which I feel we can take it up separately.
@the-other-tim-brown : what do you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
