nsivabalan commented on code in PR #13305:
URL: https://github.com/apache/hudi/pull/13305#discussion_r2125062305
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/WriteStatus.java:
##########
@@ -76,16 +78,22 @@ public class WriteStatus implements Serializable {
private final boolean trackSuccessRecords;
private final transient Random random;
- public WriteStatus(Boolean trackSuccessRecords, Double failureFraction) {
+ public WriteStatus(Boolean trackSuccessRecords, Double failureFraction,
Boolean updatesMetadataTable) {
Review Comment:
yes, we are retaining b/w compatible constructors.
so, it should not break anything.
as far as metadata table is concerned, don't think anyone can define their
own write status for metadata table.
so, that leaves only data table.
may be we can add additional condition to isStreamingWriteEnabled() to
account for write status class in use for data table. only if not set, or the
default value of org.apache.hudi.client.WriteStatus, we can enable streaming
writes, if not, we can disable it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
