the-other-tim-brown commented on code in PR #13445:
URL: https://github.com/apache/hudi/pull/13445#discussion_r2152444350
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -1009,40 +1017,38 @@ private static boolean
isDeleteRecord(HoodieTableMetaClient dataTableMetaClient,
}
}
- private static Map<String, HoodieRecord> getLogRecords(List<String>
logFilePaths,
+ private static <T> ClosableIterator<HoodieRecord<T>>
getLogRecords(List<String> logFilePaths,
HoodieTableMetaClient
datasetMetaClient,
Option<Schema>
writerSchemaOpt,
String
latestCommitTimestamp,
- EngineType
engineType) {
- if (writerSchemaOpt.isPresent()) {
+ String partitionPath,
+
HoodieReaderContext<T> readerContext) {
+ if (writerSchemaOpt.isPresent() && !logFilePaths.isEmpty()) {
+ List<HoodieLogFile> logFiles =
logFilePaths.stream().map(HoodieLogFile::new).collect(Collectors.toList());
+ FileSlice fileSlice = new FileSlice(partitionPath,
logFiles.get(0).getFileId(), logFiles.get(0).getDeltaCommitTime());
Review Comment:
Right now we don't rely on the instant time anywhere in the FileGroupReader
but we can change this is there is a way to set it properly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
