danny0405 commented on code in PR #13445:
URL: https://github.com/apache/hudi/pull/13445#discussion_r2153448619


##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/BaseSparkInternalRowReaderContext.java:
##########
@@ -171,9 +183,6 @@ public Comparable convertValueToEngineType(Comparable 
value) {
 
   @Override
   public InternalRow getDeleteRow(InternalRow record, String recordKey) {
-    if (record != null) {

Review Comment:
   Returns a `InternalRow` with just record key and patition path set up there 
will lost the other payload fields, not sure if it works for cdc read 
scenarios(the deletes for retraction)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to