the-other-tim-brown commented on PR #13445: URL: https://github.com/apache/hudi/pull/13445#issuecomment-2992150146
> @the-other-tim-brown I think the `emitDeletes` support for HoodieRecord iterator brings in too much overhead than I thought, can we drop it in this PR, the delete keys fetching should be just used in the legacy code path, now we have streaming write to MDT, and the code should be removed in the future anyway(once the streaming write is stable). > > The `emitDeletes` is introduced mainly for streaming read scenarios with engine specific rows. > > Also can we revert the changes for size estimation into a serapate PR to make the review of the current one easier. @danny0405 I don't understand what you are recommending here. Streaming write to the MDT is only used for Spark and I don't think there are plans to use it for other engines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
