danny0405 commented on code in PR #13445:
URL: https://github.com/apache/hudi/pull/13445#discussion_r2155802377
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -389,7 +392,8 @@ public ClosableIterator<T> getClosableIterator() throws
IOException {
*/
public ClosableIterator<HoodieRecord<T>> getClosableHoodieRecordIterator()
throws IOException {
return new CloseableMappingIterator<>(getClosableIterator(), nextRecord ->
{
- BufferedRecord<T> bufferedRecord =
BufferedRecord.forRecordWithContext(nextRecord,
readerContext.getSchemaHandler().getRequestedSchema(), readerContext,
orderingFieldName, false);
+ boolean isDelete = emitDelete &&
readerContext.isDeleteOperation(nextRecord);
Review Comment:
delete is a `DELETE`, you can not emit a delete when the `emitDelete` is
false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
