vinothchandar commented on code in PR #13414:
URL: https://github.com/apache/hudi/pull/13414#discussion_r2167891735
##########
hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java:
##########
@@ -262,7 +267,9 @@ public Map<Pair<String, String>,
List<HoodieMetadataColumnStats>> getColumnStats
* @param recordKeys The list of record keys to read
*/
@Override
- public Map<String, HoodieRecordGlobalLocation> readRecordIndex(List<String>
recordKeys) {
+ public HoodiePairData<String, HoodieRecordGlobalLocation>
readRecordIndex(HoodieData<String> recordKeys) {
+ ValidationUtils.checkState(recordKeys instanceof HoodieListData,
"readRecordIndex only support HoodieListData at the moment");
Review Comment:
I get the splitting into small PRs. but also don't want to land PRs, that
are not generalized. So this PR has to address this. This is a blocking gap IMO
for this PR..
My recommendation for these large changes (also in contributor guide) is to
first land the "interface level" changes.. before adding functionality.. (Not
the other way around.. where we land functionality, break some layering or
interfaces. this could leave the code broken in case we don't have time to fix
for e.g)
To solve the problem of multiple PRs, you can stack PRs. so its easy to
understand what the direction is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
