Davis-Zhang-Onehouse commented on code in PR #13414: URL: https://github.com/apache/hudi/pull/13414#discussion_r2168021589
########## hudi-common/src/main/java/org/apache/hudi/metadata/HoodieIndexVersion.java: ########## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.metadata; + +import org.apache.hudi.common.model.HoodieIndexDefinition; +import org.apache.hudi.common.table.HoodieTableVersion; +import org.apache.hudi.common.util.ValidationUtils; +import org.apache.hudi.exception.HoodieException; + +import java.util.Arrays; +import java.util.List; + +public enum HoodieIndexVersion { + ALL_PARTITIONS_ONE(MetadataPartitionType.ALL_PARTITIONS, 1, Arrays.asList("0.14.0")), Review Comment: I mean I done in a separate commits in the same PR. Since it touches a lot of things, make it a separate commit allows you to review it easily. Also I hit some issues with the approach. Because we have separate enum for different index, the it requires jackson to do polymorphism and I couldn't get it working after trial and error. tmr let's discuss. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
