Davis-Zhang-Onehouse commented on code in PR #13414:
URL: https://github.com/apache/hudi/pull/13414#discussion_r2168026314
##########
hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java:
##########
@@ -262,7 +267,9 @@ public Map<Pair<String, String>,
List<HoodieMetadataColumnStats>> getColumnStats
* @param recordKeys The list of record keys to read
*/
@Override
- public Map<String, HoodieRecordGlobalLocation> readRecordIndex(List<String>
recordKeys) {
+ public HoodiePairData<String, HoodieRecordGlobalLocation>
readRecordIndex(HoodieData<String> recordKeys) {
+ ValidationUtils.checkState(recordKeys instanceof HoodieListData,
"readRecordIndex only support HoodieListData at the moment");
Review Comment:
> So this PR has to address this. This is a blocking gap IMO for this PR..
That's useful. I mean in the end we just want to make it easy for both PR
reviewers and owners, we can choose to review all PRs before we land anything.
All changes are
- this PR
- https://github.com/apache/hudi/pull/13476 trying to add null value support
for SI
- productionization PR https://github.com/apache/hudi/pull/13437
I would suggest we walk things through f2f tmr and if we want to land things
incrementally without incur too much extra work, we can align on what PR should
do what (it means some overheads on my side which may causes delay), or we just
choose to review all 3 before landing any of them (which is easier for me as
there is only 1 acceptance criteria).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
