rahil-c commented on code in PR #13591:
URL: https://github.com/apache/hudi/pull/13591#discussion_r2229737486
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -895,7 +895,7 @@ public static <T> HoodieData<HoodieRecord>
convertMetadataToRecordIndexRecords(H
.collect(Collectors.toList());
// Extract revived and deleted keys
Pair<Set<String>, Set<String>> revivedAndDeletedKeys =
getRevivedAndDeletedKeysFromMergedLogs(dataTableMetaClient, instantTime,
allLogFilePaths, finalWriterSchemaOpt,
- currentLogFilePaths, partitionPath,
readerContextFactory.getContext());
+ currentLogFilePaths, partitionPath,
readerContextFactory.getContext(), metadataConfig);
Review Comment:
I think you are correct, that this also is the data table, will need to
check the call chain as to how we can pass the writeConfig's logScan value
correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
