rahil-c commented on code in PR #13591:
URL: https://github.com/apache/hudi/pull/13591#discussion_r2231723862
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -3110,6 +3133,7 @@ private static TypedProperties
getFileGroupReaderPropertiesFromStorageConf(Stora
storageConf.getEnum(SPILLABLE_DISK_MAP_TYPE.key(),
SPILLABLE_DISK_MAP_TYPE.defaultValue()).toString());
properties.setProperty(DISK_MAP_BITCASK_COMPRESSION_ENABLED.key(),
Boolean.toString(storageConf.getBoolean(DISK_MAP_BITCASK_COMPRESSION_ENABLED.key(),
DISK_MAP_BITCASK_COMPRESSION_ENABLED.defaultValue())));
+
properties.setProperty(HoodieReaderConfig.ENABLE_OPTIMIZED_LOG_BLOCKS_SCAN.key(),
HoodieReaderConfig.ENABLE_OPTIMIZED_LOG_BLOCKS_SCAN.defaultValue());
Review Comment:
@lokeshj1703 Are you sure though that the Storage configuration would have
the `ENABLE_OPTIMIZED_LOG_BLOCKS_SCAN.key()` present?
Based on storageConf class and its child class, I dont think this specific
logBlockScan config would be present.
https://github.com/apache/hudi/blob/master/hudi-io/src/main/java/org/apache/hudi/storage/StorageConfiguration.java#L33
https://github.com/apache/hudi/blob/master/hudi-hadoop-common/src/main/java/org/apache/hudi/storage/hadoop/HadoopStorageConfiguration.java
Which is why I opted on setting the default value here in this `properties`.
Let me know if my understanding is incorrect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
