rahil-c commented on code in PR #13591:
URL: https://github.com/apache/hudi/pull/13591#discussion_r2231733931


##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -2563,7 +2583,8 @@ public static HoodieData<HoodieRecord> 
convertFilesToPartitionStatsRecords(Hoodi
                                                                              
HoodieMetadataConfig metadataConfig,
                                                                              
HoodieTableMetaClient dataTableMetaClient,
                                                                              
Lazy<Option<Schema>> lazyWriterSchemaOpt,
-                                                                             
Option<HoodieRecordType> recordTypeOpt) {
+                                                                             
Option<HoodieRecordType> recordTypeOpt,
+                                                                             
boolean enableOptimizeLogBlocksScan) {

Review Comment:
   I think we probably should if storage conf does not have this key 
https://github.com/apache/hudi/pull/13591#discussion_r2231723862, and using the 
default value is not ideal.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to