danny0405 commented on code in PR #13591:
URL: https://github.com/apache/hudi/pull/13591#discussion_r2232826648
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -2771,14 +2797,15 @@ public static List<String>
generateKeyPrefixes(List<String> columnsToIndex, Stri
private static List<HoodieColumnRangeMetadata<Comparable>>
translateWriteStatToFileStats(HoodieWriteStat writeStat,
HoodieTableMetaClient datasetMetaClient,
List<String> columnsToIndex,
-
Option<Schema> writerSchemaOpt) {
+
Option<Schema> writerSchemaOpt,
+
boolean enableOptimizeLogBlocksScan) {
if (writeStat instanceof HoodieDeltaWriteStat && ((HoodieDeltaWriteStat)
writeStat).getColumnStats().isPresent()) {
Map<String, HoodieColumnRangeMetadata<Comparable>> columnRangeMap =
((HoodieDeltaWriteStat) writeStat).getColumnStats().get();
return new ArrayList<>(columnRangeMap.values());
}
String filePath = writeStat.getPath();
- return getFileStatsRangeMetadata(writeStat.getPartitionPath(),
getFileNameFromPath(filePath), datasetMetaClient, columnsToIndex, false, -1);
+ return getFileStatsRangeMetadata(writeStat.getPartitionPath(),
getFileNameFromPath(filePath), datasetMetaClient, columnsToIndex, false, -1,
enableOptimizeLogBlocksScan);
Review Comment:
Hmm, it looks like most of the flags in this class in unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
