rahil-c commented on code in PR #13591:
URL: https://github.com/apache/hudi/pull/13591#discussion_r2233101404
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieFileGroupReaderBasedRecordReader.java:
##########
@@ -153,6 +154,8 @@ public
HoodieFileGroupReaderBasedRecordReader(HiveReaderCreator readerCreator,
.withStart(fileSplit.getStart())
.withLength(fileSplit.getLength())
.withShouldUseRecordPosition(false)
+
.withEnableOptimizedLogBlockScan(jobConf.getBoolean(HoodieReaderConfig.ENABLE_OPTIMIZED_LOG_BLOCKS_SCAN.key(),
Review Comment:
@danny0405 The props that are passed in this usage are only getting table
properties,
https://github.com/apache/hudi/blob/master/hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieFileGroupReaderBasedRecordReader.java#L130
Which I do not believe will contain the enableOptimizeLogScan key.
When checking some older abstraction that would read log files in
hudi-hadoop mr module, i see we actually do read this value from the `jobConf`.
https://github.com/apache/hudi/blob/master/hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/RealtimeCompactedRecordReader.java#L104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
