rahil-c commented on code in PR #13591:
URL: https://github.com/apache/hudi/pull/13591#discussion_r2233196599
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -444,12 +446,12 @@ public static Map<String, HoodieData<HoodieRecord>>
convertMetadataToRecords(Hoo
// Generate Hoodie Pair data of partition name and list of column range
metadata for all the files in that partition
boolean isDeletePartition =
commitMetadata.getOperationType().equals(WriteOperationType.DELETE_PARTITION);
final HoodieData<HoodieRecord> partitionStatsRDD =
convertMetadataToPartitionStatRecords(commitMetadata, context,
- dataMetaClient, tableMetadata, metadataConfig, recordTypeOpt,
isDeletePartition);
+ dataMetaClient, tableMetadata, metadataConfig, recordTypeOpt,
isDeletePartition, enableOptimizeLogBlocksScan);
partitionToRecordsMap.put(MetadataPartitionType.PARTITION_STATS.getPartitionPath(),
partitionStatsRDD);
}
if
(enabledPartitionTypes.contains(MetadataPartitionType.RECORD_INDEX.getPartitionPath()))
{
partitionToRecordsMap.put(MetadataPartitionType.RECORD_INDEX.getPartitionPath(),
convertMetadataToRecordIndexRecords(context, commitMetadata, metadataConfig,
- dataMetaClient, writesFileIdEncoding, instantTime, engineType));
+ dataMetaClient, writesFileIdEncoding, instantTime, engineType,
enableOptimizeLogBlocksScan));
Review Comment:
When tracing thru the code path I do not think this actually leverages the
props. I think we will need to pass this thru only for this `RECORD_INDEX` use
case.
This RECORD_INDEX case invokes the `getRevivedAndDeletedKeysFromMergedLogs`
which seems to be having to deal with merged log files
https://github.com/apache/hudi/blob/49ac549cf5ef7dd635d069dd44100ab98e6f19d1/hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java#L941
Eventually this invokes the `getLogRecords` method which based on the
builder seems not to have a props being passed thru it.
https://github.com/apache/hudi/blob/49ac549cf5ef7dd635d069dd44100ab98e6f19d1/hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java#L1043,
hence why i am passing this flag thru.
Please let me know if my understanding is incorrect here if you can link a
pointer to why we do not need would be helpful.
cc @lokeshj1703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
