vinothchandar commented on code in PR #13577:
URL: https://github.com/apache/hudi/pull/13577#discussion_r2248985066
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/TransactionManager.java:
##########
@@ -38,40 +43,131 @@ public class TransactionManager implements Serializable,
AutoCloseable {
protected static final Logger LOG =
LoggerFactory.getLogger(TransactionManager.class);
protected final LockManager lockManager;
protected final boolean isLockRequired;
+ private final transient TimeGenerator timeGenerator;
+ protected boolean hasLock;
protected Option<HoodieInstant> changeActionInstant = Option.empty();
private Option<HoodieInstant> lastCompletedActionInstant = Option.empty();
public TransactionManager(HoodieWriteConfig config, HoodieStorage storage) {
- this(new LockManager(config, storage), config.isLockRequired());
+ this(new LockManager(config, storage), config);
}
- protected TransactionManager(LockManager lockManager, boolean
isLockRequired) {
+ public TransactionManager(HoodieWriteConfig config, boolean isLockRequired,
HoodieStorage storage) {
Review Comment:
nts: ensure the transaction manager is only created once in the writeClient
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
