vinothchandar commented on code in PR #13577:
URL: https://github.com/apache/hudi/pull/13577#discussion_r2250215594
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/savepoint/SavepointActionExecutor.java:
##########
@@ -137,16 +138,18 @@ public HoodieSavepointMetadata execute() {
}, null);
}
- HoodieSavepointMetadata metadata =
TimelineMetadataUtils.convertSavepointMetadata(user, comment, latestFilesMap);
- // Nothing to save in the savepoint
- table.getActiveTimeline().createNewInstant(
- instantGenerator.createNewInstant(HoodieInstant.State.INFLIGHT,
HoodieTimeline.SAVEPOINT_ACTION, instantTime));
- table.getActiveTimeline()
- .saveAsComplete(
- true,
instantGenerator.createNewInstant(HoodieInstant.State.INFLIGHT,
HoodieTimeline.SAVEPOINT_ACTION, instantTime), Option.of(metadata),
- savepointCompletedInstant ->
table.getMetaClient().getTableFormat().savepoint(savepointCompletedInstant,
table.getContext(), table.getMetaClient(), table.getViewManager()));
- LOG.info("Savepoint " + instantTime + " created");
- return metadata;
+ try (TransactionManager transactionManager = new
TransactionManager(config, table.getStorage())) {
Review Comment:
I changed this to pass in completionTime from client call site
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
