vinothchandar commented on code in PR #13577:
URL: https://github.com/apache/hudi/pull/13577#discussion_r2250215016
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1035,15 +1021,12 @@ String startCommit(Option<String> providedInstantTime,
String actionType, Hoodie
}
if (ClusteringUtils.isClusteringOrReplaceCommitAction(actionType)) {
- instant =
metaClient.getActiveTimeline().createRequestedCommitWithReplaceMetadata(instantTime,
actionType);
+
metaClient.getActiveTimeline().createRequestedCommitWithReplaceMetadata(instantTime,
actionType);
} else {
- instant = metaClient.createNewInstant(State.REQUESTED, actionType,
instantTime);
- metaClient.getActiveTimeline().createNewInstant(instant);
+
metaClient.getActiveTimeline().createNewInstant(metaClient.createNewInstant(State.REQUESTED,
actionType, instantTime));
}
- } finally {
- txnManager.endStateChange(Option.ofNullable(instant));
Review Comment:
this can also be simplified.. Will plan a another cleanup PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
