vinothchandar commented on code in PR #13577:
URL: https://github.com/apache/hudi/pull/13577#discussion_r2252846179


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanActionExecutor.java:
##########
@@ -222,7 +222,7 @@ private HoodieCleanMetadata runClean(HoodieTable<T, I, K, 
O> table, HoodieInstan
       );
       this.txnManager.beginStateChange(Option.of(inflightInstant), 
Option.empty());
       writeTableMetadata(metadata, inflightInstant.requestedTime());
-      table.getActiveTimeline().transitionCleanInflightToComplete(false, 
inflightInstant, Option.of(metadata));

Review Comment:
   I ll check



##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/CompactHelpers.java:
##########
@@ -77,26 +77,26 @@ public HoodieCommitMetadata createCompactionMetadata(
     return metadata;
   }
 
-  public void completeInflightCompaction(HoodieTable table, String 
compactionCommitTime, HoodieCommitMetadata commitMetadata) {
+  public void completeInflightCompaction(HoodieTable table, String 
compactionCommitTime, HoodieCommitMetadata commitMetadata, String 
completionInstant) {

Review Comment:
   will fix



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to