alexr17 commented on code in PR #13836:
URL: https://github.com/apache/hudi/pull/13836#discussion_r2331657317
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/StorageBasedLockProvider.java:
##########
@@ -267,6 +268,18 @@ private synchronized void shutdown(boolean
fromShutdownHook) {
} catch (Exception e) {
logger.error("Owner {}: Heartbeat manager failed to close.", ownerId, e);
}
+ try {
+ this.auditService.ifPresent(auditService -> {
+ try {
+ auditService.close();
+ } catch (Exception e) {
+ logger.error("Owner {}: Audit service failed to close.", ownerId, e);
+ }
+ });
+ this.auditService = Option.empty();
+ } catch (Exception e) {
+ logger.error("Owner {}: Failed to close audit service.", ownerId, e);
+ }
Review Comment:
no, if the shutdown hook is invoked we do not want to do anything extra.
notice we don't close the storage lock client either
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
