alexr17 commented on code in PR #13836:
URL: https://github.com/apache/hudi/pull/13836#discussion_r2331659549
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/StorageBasedLockProvider.java:
##########
@@ -463,6 +487,7 @@ private synchronized boolean tryExpireCurrentLock(boolean
fromShutdownHook) {
return false;
case SUCCESS:
logInfoLockState(RELEASED);
+ recordAuditOperation(AuditOperationState.END,
System.currentTimeMillis());
Review Comment:
generally no, in these situations errors will be thrown and the job will
fail. the goal here is to verify correctness - silent errors which we would
otherwise not know about. i suppose we can record some error state in the
operation though. let's wait until the implementation PR so you can deliver
final thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
