the-other-tim-brown commented on code in PR #13947:
URL: https://github.com/apache/hudi/pull/13947#discussion_r2365905236
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##########
@@ -1440,6 +1460,18 @@ public TableBuilder fromProperties(Properties
properties) {
if
(hoodieConfig.contains(HoodieTableConfig.RELATIVE_INDEX_DEFINITION_PATH)) {
setIndexDefinitionPath(hoodieConfig.getString(HoodieTableConfig.RELATIVE_INDEX_DEFINITION_PATH));
}
+ // set delete field and marker value, if both are present
+ // check if config is prefixed for the table config or passed in from
older write config properties
+ if (hoodieConfig.contains(RECORD_MERGE_PROPERTY_PREFIX + DELETE_KEY)) {
+ String deleteFieldName =
hoodieConfig.getString(RECORD_MERGE_PROPERTY_PREFIX + DELETE_KEY);
+ String markerValue =
hoodieConfig.getString(RECORD_MERGE_PROPERTY_PREFIX + DELETE_MARKER);
+ setRecordDeleteFieldAndMarker(deleteFieldName, markerValue);
+ }
+ if (hoodieConfig.contains(DELETE_KEY)) {
Review Comment:
Yes we should document this in the release notes but I am worried people
will not read with that detail and upgrading will cause issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
