yihua commented on code in PR #13947:
URL: https://github.com/apache/hudi/pull/13947#discussion_r2366366517
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/EightToNineUpgradeHandler.java:
##########
@@ -201,16 +202,37 @@ private void
reconcileMergePropertiesConfig(Map<ConfigProperty, String> tablePro
tablePropsToAdd.put(
ConfigProperty.key(RECORD_MERGE_PROPERTY_PREFIX +
PARTIAL_UPDATE_UNAVAILABLE_VALUE).noDefaultValue(), // // to be fixed once we
land PR #13721.
Review Comment:
@nsivabalan @linliu-code (independent of this PR) does this require
additional fix given #13721 is merged?
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/upgrade/TestEightToNineUpgradeHandler.java:
##########
@@ -188,7 +189,8 @@ static Stream<Arguments> payloadClassTestCases() {
),
Arguments.of(
MySqlDebeziumAvroPayload.class.getName(),
- "",
+ RECORD_MERGE_PROPERTY_PREFIX + DELETE_KEY +
"=_change_operation_type,"
+ + RECORD_MERGE_PROPERTY_PREFIX + DELETE_MARKER + "=d",
Review Comment:
Same on validating that the ordering field is added to the table config
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/upgrade/TestEightToNineUpgradeHandler.java:
##########
@@ -173,8 +173,9 @@ static Stream<Arguments> payloadClassTestCases() {
),
Arguments.of(
PostgresDebeziumAvroPayload.class.getName(),
- RECORD_MERGE_PROPERTY_PREFIX + PARTIAL_UPDATE_UNAVAILABLE_VALUE
- + "=" + DEBEZIUM_UNAVAILABLE_VALUE,
+ RECORD_MERGE_PROPERTY_PREFIX + PARTIAL_UPDATE_UNAVAILABLE_VALUE +
"=" + DEBEZIUM_UNAVAILABLE_VALUE + ","
+ + RECORD_MERGE_PROPERTY_PREFIX + DELETE_KEY +
"=_change_operation_type,"
+ + RECORD_MERGE_PROPERTY_PREFIX + DELETE_MARKER + "=d",
Review Comment:
Also validate that the ordering field is added to the table config, besides
delete configs?
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/upgrade/TestEightToNineUpgradeHandler.java:
##########
@@ -188,7 +189,8 @@ static Stream<Arguments> payloadClassTestCases() {
),
Arguments.of(
MySqlDebeziumAvroPayload.class.getName(),
- "",
+ RECORD_MERGE_PROPERTY_PREFIX + DELETE_KEY +
"=_change_operation_type,"
Review Comment:
The redundant arguments below for `MySqlDebeziumAvroPayload` (last one in
the combinations) should be removed.
```
Arguments.of(
MySqlDebeziumAvroPayload.class.getName(),
"",
EVENT_TIME_ORDERING.name(),
null,
"MySqlDebeziumAvroPayload"
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
