the-other-tim-brown commented on code in PR #13947:
URL: https://github.com/apache/hudi/pull/13947#discussion_r2366429294
##########
hudi-common/src/main/java/org/apache/hudi/common/util/HoodieRecordUtils.java:
##########
@@ -222,10 +220,9 @@ public static String
getCurrentLocationInstant(HoodieRecord<?> record) {
}
public static List<String> getOrderingFieldNames(RecordMergeMode mergeMode,
- TypedProperties props,
HoodieTableMetaClient
metaClient) {
return mergeMode == RecordMergeMode.COMMIT_TIME_ORDERING
? Collections.emptyList()
- :
Option.ofNullable(ConfigUtils.getOrderingFields(props)).map(Arrays::asList).orElseGet(()
-> metaClient.getTableConfig().getOrderingFields());
+ : metaClient.getTableConfig().getOrderingFields();
Review Comment:
Right, the stored config value should be used to guarantee consistency
between reads and writes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
