danny0405 commented on code in PR #13951:
URL: https://github.com/apache/hudi/pull/13951#discussion_r2365909555
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -289,6 +290,7 @@ protected boolean isUpdateRecord(HoodieRecord<T>
hoodieRecord) {
private void bufferRecord(HoodieRecord<T> hoodieRecord) {
Schema schema = useWriterSchema ? writeSchemaWithMetaFields : writeSchema;
+ DeleteContext recordDeleteContext = useWriterSchema ?
deleteContextWithMetaFields : deleteContext;
Review Comment:
the meta fields are not there for in-memory records in write path, so the
`DeleteContext#withReaderSchema` does not really work. So just maintain one
singleton `DeleteContext` in the write handle, and within
`HoodieRecord.checkIsDelete`, handle the `HoodieOperation` specifically because
it is already there in the record.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
