danny0405 commented on code in PR #13951:
URL: https://github.com/apache/hudi/pull/13951#discussion_r2365919193
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/common/model/HoodieSparkRecord.java:
##########
@@ -257,26 +258,12 @@ public HoodieRecord truncateRecordKey(Schema
recordSchema, Properties props, Str
}
@Override
- protected boolean checkIsDelete(Schema recordSchema, Properties props) {
+ protected boolean checkIsDelete(Schema recordSchema, Properties props,
DeleteContext deleteContext) {
Review Comment:
some thoughts:
- the param should be just `DeleteContext`, the context already holds the
record schema;
- hoodie operation should be handled separately because the meta fields are
not there in write path.
- for the other logic, go through
`xxx.getFieldAccessorInstance().isDeleteRecord`, that is how we unify the logic
or read/write paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
