danny0405 commented on code in PR #13951:
URL: https://github.com/apache/hudi/pull/13951#discussion_r2365918474
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteHandle.java:
##########
@@ -140,6 +143,8 @@ protected HoodieWriteHandle(HoodieWriteConfig config,
String instantTime, String
&& hoodieTable.getMetaClient().getTableConfig().getRecordMergeMode()
== EVENT_TIME_ORDERING
&& ConfigUtils.isTrackingEventTimeWatermark(config.getProps());
this.keepConsistentLogicalTimestamp = isTrackingEventTimeWatermark &&
ConfigUtils.shouldKeepConsistentLogicalTimestamp(config.getProps());
+ this.deleteContext = new
DeleteContext(ConfigUtils.getMergeProps(config.getProps(),
hoodieTable.getMetaClient().getTableConfig().getProps()),
writeSchema).withReaderSchema(writeSchema);
+ this.deleteContextWithMetaFields = new
DeleteContext(ConfigUtils.getMergeProps(config.getProps(),
hoodieTable.getMetaClient().getTableConfig().getProps()),
writeSchemaWithMetaFields).withReaderSchema(writeSchemaWithMetaFields);
Review Comment:
the meta fields are not there for in-memory records in write path, so the
`DeleteContext#withReaderSchema` does not really work. So just maintain one
singleton `DeleteContext` in the write handle should be fine, can use the flag
`preserveMetadata` to decide which schema to use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
