umehrot2 commented on a change in pull request #2326:
URL: https://github.com/apache/hudi/pull/2326#discussion_r544769103
##########
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieROTablePathFilter.java
##########
@@ -56,6 +58,15 @@
public class HoodieROTablePathFilter implements Configurable, PathFilter,
Serializable {
private static final long serialVersionUID = 1L;
+ public static final String METADATA_PREFIX = "hoodie.metadata";
+
+ // List using internal metadata table which saves file listings
+ public static final String METADATA_ENABLE_PROP = METADATA_PREFIX +
".enable";
+ public static final boolean DEFAULT_METADATA_ENABLE = false;
Review comment:
Makes sense. I introduced a `true` default for the readers, but just a
but concerned about the additional overhead this introduces in the regular (non
metadata table) hudi path, as it would keep checking for the metadata folder
and call `getFileStatus()` and then fail. This can be an overhead for S3.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
