umehrot2 commented on a change in pull request #2326:
URL: https://github.com/apache/hudi/pull/2326#discussion_r545510206



##########
File path: 
hudi-spark/src/test/scala/org/apache/hudi/functional/TestCOWDataSource.scala
##########
@@ -194,4 +195,42 @@ class TestCOWDataSource extends HoodieClientTestBase {
       .load(basePath)
     assertEquals(hoodieIncViewDF2.count(), insert2NewKeyCnt)
   }
+
+  @Test def testCopyOnWriteStorageWithMetadata() {

Review comment:
       Testing from `TestHoodieROTablePathFilter` directly seems to be quite a 
task in itself, given the logic inside it. `HoodieTestTable` will have to be 
modified to be able to simulate metadata table, and create relevant HFiles 
inside the metadata table. Let me create a Jira for this for now and come to it 
later.
   
   For now want to merge this, and focus on `get all partition paths` before I 
head for my time off.  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to