vinothchandar commented on a change in pull request #2326:
URL: https://github.com/apache/hudi/pull/2326#discussion_r545145067
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java
##########
@@ -128,24 +128,23 @@ public Builder retainCommits(int commitsRetained) {
public HoodieMetadataConfig build() {
HoodieMetadataConfig config = new HoodieMetadataConfig(props);
setDefaultOnCondition(props, !props.containsKey(METADATA_ENABLE_PROP),
METADATA_ENABLE_PROP,
- String.valueOf(DEFAULT_METADATA_ENABLE));
+ String.valueOf(DEFAULT_METADATA_ENABLE));
Review comment:
trying to understand these formatting changes. can we use whichever
aligns with checkstyle?
##########
File path:
hudi-spark/src/test/scala/org/apache/hudi/functional/TestCOWDataSource.scala
##########
@@ -194,4 +195,42 @@ class TestCOWDataSource extends HoodieClientTestBase {
.load(basePath)
assertEquals(hoodieIncViewDF2.count(), insert2NewKeyCnt)
}
+
+ @Test def testCopyOnWriteStorageWithMetadata() {
Review comment:
should we test via `TestHoodieROTablePathFilter` directly? in the
future, Datasource may not call the path filter at all for e.g?
##########
File path:
hudi-spark/src/test/scala/org/apache/hudi/functional/TestCOWDataSource.scala
##########
@@ -194,4 +195,42 @@ class TestCOWDataSource extends HoodieClientTestBase {
.load(basePath)
assertEquals(hoodieIncViewDF2.count(), insert2NewKeyCnt)
}
+
+ @Test def testCopyOnWriteStorageWithMetadata() {
Review comment:
any way to just parameterize this entire test with and without metadata.
might be easier to extend down the line as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
