PavithranRick commented on code in PR #14261:
URL: https://github.com/apache/hudi/pull/14261#discussion_r2579198792
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/BaseHoodieTimeline.java:
##########
@@ -114,6 +114,22 @@ protected void appendInstants(List<HoodieInstant>
newInstants) {
clearState();
}
+ /**
+ * Helper method to append loaded instants to the timeline, filtering out
duplicates.
+ * This is used by both time-range and limit-based loading to avoid code
duplication.
+ *
+ * @param loadedInstants The list of instants that were loaded to readCommit
field of timeline
+ */
+ protected void appendLoadedInstants(List<HoodieInstant> loadedInstants) {
Review Comment:
We have another method appendInstants (which does something different when
compared to appendLoadedInstants)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
