PavithranRick commented on code in PR #14261:
URL: https://github.com/apache/hudi/pull/14261#discussion_r2579234070
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ArchivedTimelineV1.java:
##########
@@ -209,13 +222,44 @@ public void loadCompactionDetailsInMemory(String
compactionInstantTime) {
@Override
public void loadCompactionDetailsInMemory(String startTs, String endTs) {
// load compactionPlan
- loadInstants(new ClosedClosedTimeRangeFilter(startTs, endTs), null, true,
+ List<HoodieInstant> loadedInstants = loadInstants(new
ClosedClosedTimeRangeFilter(startTs, endTs), null, true,
record -> {
// Older files don't have action state set.
Object action = record.get(ACTION_STATE);
return
record.get(ACTION_TYPE_KEY).toString().equals(HoodieTimeline.COMPACTION_ACTION)
&& (action == null ||
org.apache.hudi.common.table.timeline.HoodieInstant.State.INFLIGHT.toString().equals(action.toString()));
});
+ appendLoadedInstants(loadedInstants);
+ }
+
+ @Override
+ public void loadCompactionDetailsInMemory(int limit) {
+ loadInstantsWithLimit(limit, true,
+ record -> {
+ Object actionState = record.get(ACTION_STATE);
+ // Older files & archivedTimelineV2 don't have action state set.
+ return
record.get(ACTION_TYPE_KEY).toString().equals(HoodieTimeline.COMPACTION_ACTION)
+ && (actionState == null ||
org.apache.hudi.common.table.timeline.HoodieInstant.State.INFLIGHT.toString().equals(actionState.toString()));
+ });
Review Comment:
Both approaches cache results in the timeline's internal `instants` list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
