nsivabalan commented on code in PR #14261:
URL: https://github.com/apache/hudi/pull/14261#discussion_r2579386095
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ArchivedTimelineV1.java:
##########
@@ -244,11 +288,23 @@ private List<HoodieInstant>
loadInstants(HoodieArchivedTimeline.TimeRangeFilter
private List<HoodieInstant>
loadInstants(HoodieArchivedTimeline.TimeRangeFilter filter, LogFileFilter
logFileFilter, boolean loadInstantDetails, Function<GenericRecord, Boolean>
commitsFilter) {
InstantsLoader loader = new InstantsLoader(loadInstantDetails);
timelineLoader.loadInstants(
- metaClient, filter, Option.ofNullable(logFileFilter), LoadMode.PLAN,
commitsFilter, loader);
+ metaClient, filter, Option.ofNullable(logFileFilter), LoadMode.PLAN,
commitsFilter, loader, Option.empty());
return loader.getInstantsInRangeCollected().values()
.stream().flatMap(Collection::stream).sorted().collect(Collectors.toList());
}
+ private void loadInstantsWithLimit(int limit, boolean loadInstantDetails,
Function<GenericRecord, Boolean> commitsFilter) {
Review Comment:
lets rename this to `loadAndAppendInstantsWithLimit`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
