the-other-tim-brown commented on code in PR #17573: URL: https://github.com/apache/hudi/pull/17573#discussion_r2627512344
########## hudi-spark-datasource/hudi-spark3.3.x/src/main/scala/org/apache/spark/sql/avro/AvroDeserializerInternal.scala: ########## @@ -49,17 +51,17 @@ import scala.collection.JavaConverters._ * * PLEASE REFRAIN MAKING ANY CHANGES TO THIS CODE UNLESS ABSOLUTELY NECESSARY */ -private[sql] class AvroDeserializer(rootAvroType: Schema, +private[sql] class AvroDeserializerInternal(rootType: HoodieSchema, Review Comment: Nitpick: fix indentation to align args ########## hudi-spark-datasource/hudi-spark3.3.x/src/main/scala/org/apache/spark/sql/avro/AvroDeserializerInternal.scala: ########## @@ -17,13 +17,15 @@ package org.apache.spark.sql.avro Review Comment: Does this still need to be on the spark path or can we move this to the Hoodie path? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
