yihua commented on code in PR #17573:
URL: https://github.com/apache/hudi/pull/17573#discussion_r2628769708
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieBaseRelation.scala:
##########
@@ -369,15 +367,15 @@ abstract class HoodieBaseRelation(val sqlContext:
SQLContext,
val fileSplits = collectFileSplits(partitionFilters, dataFilters)
- val tableAvroSchemaStr = tableAvroSchema.toString
+ val tableSchemaStr = tableSchema.toString
- val tableSchema = HoodieTableSchema(tableStructSchema, tableAvroSchemaStr,
internalSchemaOpt)
+ val schema = HoodieTableSchema(tableStructSchema, tableSchemaStr,
internalSchemaOpt)
Review Comment:
Could we directly store `HoodieSchema` in `HoodieTableSchema`?
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieBaseRelation.scala:
##########
@@ -369,15 +367,15 @@ abstract class HoodieBaseRelation(val sqlContext:
SQLContext,
val fileSplits = collectFileSplits(partitionFilters, dataFilters)
- val tableAvroSchemaStr = tableAvroSchema.toString
+ val tableSchemaStr = tableSchema.toString
- val tableSchema = HoodieTableSchema(tableStructSchema, tableAvroSchemaStr,
internalSchemaOpt)
+ val schema = HoodieTableSchema(tableStructSchema, tableSchemaStr,
internalSchemaOpt)
Review Comment:
Change `avroSchemaStr` to `tableSchemaStr` in `HoodieTableSchema`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
