rahil-c commented on code in PR #17573:
URL: https://github.com/apache/hudi/pull/17573#discussion_r2631339320
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/avro/HoodieSparkSchemaConverters.scala:
##########
@@ -102,7 +102,14 @@ object HoodieSparkSchemaConverters {
val fields = st.map { f =>
val fieldSchema = toHoodieType(f.dataType, f.nullable, f.name,
childNameSpace)
val doc = f.getComment.orNull
- HoodieSchemaField.of(f.name, fieldSchema, doc)
Review Comment:
<img width="763" height="188" alt="Screenshot 2025-12-18 at 6 20 30 AM"
src="https://github.com/user-attachments/assets/decefdb9-a69d-4807-a01f-06c396739f66";
/>
There are no production usages of it, so it can be removed. I think when
looking at HoodieAvroUtils we also did not have any three arg constructor like
this so I am thinking it might be less confusing and have the caller be
explicit on what they want default val as.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
