the-other-tim-brown commented on code in PR #17660: URL: https://github.com/apache/hudi/pull/17660#discussion_r2651366106
########## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestLanceDataSource.scala: ########## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.functional + +import org.apache.hudi.DataSourceWriteOptions._ +import org.apache.hudi.DefaultSparkRecordMerger +import org.apache.hudi.common.table.HoodieTableConfig +import org.apache.hudi.config.HoodieWriteConfig +import org.apache.hudi.testutils.HoodieSparkClientTestBase + +import org.apache.spark.sql.{SaveMode, SparkSession} +import org.junit.jupiter.api.{AfterEach, BeforeEach, Test} +import org.junit.jupiter.api.Assertions.assertEquals +import org.junit.jupiter.api.condition.DisabledIfSystemProperty + +/** + * Basic functional tests for Lance file format with Hudi Spark datasource. + */ +@DisabledIfSystemProperty(named = "lance.skip.tests", matches = "true") +class TestLanceDataSource extends HoodieSparkClientTestBase { + + var spark: SparkSession = _ + + @BeforeEach + override def setUp(): Unit = { + super.setUp() + spark = sqlContext.sparkSession + } + + @AfterEach + override def tearDown(): Unit = { + super.tearDown() + spark = null + } + + @Test + def testBasicWriteAndRead(): Unit = { + val tableName = "test_lance_table" + val tablePath = s"$basePath/$tableName" + + // Create test data + val records = Seq( + (1, "Alice", 30, 95.5), + (2, "Bob", 25, 87.3), + (3, "Charlie", 35, 92.1) + ) + val df = spark.createDataFrame(records).toDF("id", "name", "age", "score") + + // Write to Hudi table with Lance base file format + df.write + .format("hudi") + .option(HoodieTableConfig.BASE_FILE_FORMAT.key(), "LANCE") + .option(RECORDKEY_FIELD.key(), "id") + .option(PRECOMBINE_FIELD.key(), "age") + .option(TABLE_NAME.key(), tableName) + .option(HoodieWriteConfig.TBL_NAME.key(), tableName) + .option(HoodieWriteConfig.RECORD_MERGE_IMPL_CLASSES.key(), classOf[DefaultSparkRecordMerger].getName) + .mode(SaveMode.Overwrite) + .save(tablePath) + + // Read back and verify + val readDf = spark.read + .format("hudi") + .load(tablePath) + + val result = readDf.select("id", "name", "age", "score") + .orderBy("id") + .collect() + + assertEquals(3, result.length, "Should read 3 records") Review Comment: The assertions are quite verbose. Is there a way to use Rows or Sequences to make this leaner? I see the next PR for Lance also adds more tests so it will be best to establish any required utilities now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
