rahil-c commented on code in PR #17660:
URL: https://github.com/apache/hudi/pull/17660#discussion_r2652068430


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/HoodieFileGroupReaderBasedFileFormat.scala:
##########
@@ -424,8 +430,14 @@ class HoodieFileGroupReaderBasedFileFormat(tablePath: 
String,
   override def inferSchema(sparkSession: SparkSession, options: Map[String, 
String], files: Seq[FileStatus]): Option[StructType] = {

Review Comment:
   Currently in this code path we basically leverage the `ParquetUtils` from 
`org.apache.spark.sql.execution.datasources.parquet` and `OrcUtils` from 
`org.apache.spark.sql.execution.datasources.orc` for doing the inference.
   
   @yihua so to confirm for lance we should return an exception or None?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to