the-other-tim-brown commented on code in PR #17660:
URL: https://github.com/apache/hudi/pull/17660#discussion_r2652003692
##########
pom.xml:
##########
@@ -2562,7 +2564,7 @@
<kafka.version>3.3.2</kafka.version>
<!-- Lance: Use Spark 3.4-specific artifact -->
<lance.spark.artifact>lance-spark-3.4_${scala.binary.version}</lance.spark.artifact>
- <lance.skip.tests>false</lance.skip.tests>
Review Comment:
I think that we should support 3.4 since it is supported by lance and seems
like minimal overhead at this point.
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieFileFormat.java:
##########
@@ -49,7 +49,12 @@ public enum HoodieFileFormat {
+ "way to store Hive data. It was designed to overcome limitations of
the other Hive file "
+ "formats. Using ORC files improves performance when Hive is reading,
writing, and "
+ "processing data.")
- ORC(".orc");
+ ORC(".orc"),
+
+ @EnumFieldDescription("Lance is a modern columnar data format optimized for
random access patterns, "
+ + "and designed for ML and AI workloads"
+ + "")
Review Comment:
```suggestion
@EnumFieldDescription("Lance is a modern columnar data format optimized
for random access patterns "
+ "and designed for ML and AI workloads"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
