voonhous commented on code in PR #17739: URL: https://github.com/apache/hudi/pull/17739#discussion_r2663636374
########## hudi-client/hudi-flink-client/src/test/java/org/apache/hudi/util/TestHoodieSchemaConverter.java: ########## @@ -37,6 +39,8 @@ import java.util.Arrays; +import static org.hamcrest.CoreMatchers.is; +import static org.hamcrest.MatcherAssert.assertThat; Review Comment: Super Nit: While there are some parts of our code that are using `hamcrest` for `assertThat`, I feel `assertj` is more widely used. e.g. Trino and flink-cdc chose it over hamcrest. ```java import static org.assertj.core.api.Assertions.assertThat; ``` We have both in our code base now, i feel we should clean this up in a chore PR moving forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
