danny0405 commented on code in PR #17739:
URL: https://github.com/apache/hudi/pull/17739#discussion_r2667070920
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/model/HoodieFlinkRecord.java:
##########
@@ -187,20 +188,20 @@ public Object[] getColumnValues(Schema recordSchema,
String[] columns, boolean c
@Override
public Object getColumnValueAsJava(Schema recordSchema, String column,
Properties props) {
- return getColumnValueAsJava(recordSchema, column, props, true);
+ return getColumnValueAsJava(HoodieSchema.fromAvroSchema(recordSchema),
column, props, true);
}
- private Object getColumnValueAsJava(Schema recordSchema, String column,
Properties props, boolean allowsNull) {
+ private Object getColumnValueAsJava(HoodieSchema recordSchema, String
column, Properties props, boolean allowsNull) {
boolean utcTimezone = Boolean.parseBoolean(props.getProperty(
HoodieStorageConfig.WRITE_UTC_TIMEZONE.key(),
HoodieStorageConfig.WRITE_UTC_TIMEZONE.defaultValue().toString()));
- RowDataQueryContext rowDataQueryContext =
RowDataAvroQueryContexts.fromAvroSchema(recordSchema, utcTimezone);
+ RowDataQueryContext rowDataQueryContext =
RowDataQueryContexts.fromSchema(recordSchema, utcTimezone);
return rowDataQueryContext.getFieldQueryContext(column).getValAsJava(data,
allowsNull);
}
- private Object getColumnValue(Schema recordSchema, String column, Properties
props) {
+ private Object getColumnValue(HoodieSchema recordSchema, String column,
Properties props) {
boolean utcTimezone = Boolean.parseBoolean(props.getProperty(
HoodieStorageConfig.WRITE_UTC_TIMEZONE.key(),
HoodieStorageConfig.WRITE_UTC_TIMEZONE.defaultValue().toString()));
- RowDataQueryContext rowDataQueryContext =
RowDataAvroQueryContexts.fromAvroSchema(recordSchema, utcTimezone);
+ RowDataQueryContext rowDataQueryContext =
RowDataQueryContexts.fromSchema(recordSchema, utcTimezone);
Review Comment:
confirmed that the cache should still work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
