danny0405 commented on code in PR #17739:
URL: https://github.com/apache/hudi/pull/17739#discussion_r2667070207
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/model/HoodieFlinkRecord.java:
##########
@@ -187,20 +188,20 @@ public Object[] getColumnValues(Schema recordSchema,
String[] columns, boolean c
@Override
public Object getColumnValueAsJava(Schema recordSchema, String column,
Properties props) {
- return getColumnValueAsJava(recordSchema, column, props, true);
+ return getColumnValueAsJava(HoodieSchema.fromAvroSchema(recordSchema),
column, props, true);
Review Comment:
do we have plan to replace the param as a HoodieSchema too:
`getColumnValueAsJava(HoodieSchema recordSchema` to avoid the per-record schema
creation overhead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
