yihua commented on code in PR #17772:
URL: https://github.com/apache/hudi/pull/17772#discussion_r2671004005
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/common/util/ParquetUtils.java:
##########
@@ -458,7 +457,7 @@ public Pair<ByteArrayOutputStream, Object>
serializeRecordsToLogBlock(HoodieStor
HoodieFileFormat.PARQUET, outputStream, storage, config, schema,
recordType);
while (recordItr.hasNext()) {
HoodieRecord record = recordItr.next();
- String recordKey = record.getRecordKey(readerSchema, keyFieldName);
+ String recordKey =
record.getRecordKey(HoodieSchema.fromAvroSchema(readerSchema), keyFieldName);
Review Comment:
`HoodieSchema` should be generated outside the while loop
##########
hudi-hadoop-mr/src/test/java/org/apache/hudi/hadoop/TestHoodieHiveRecord.java:
##########
@@ -62,17 +60,15 @@ void setUp() {
@Test
void testConvertColumnValueForLogicalTypeWithNullValue() {
- Schema dateSchema = Schema.create(Schema.Type.INT);
- LogicalTypes.date().addToSchema(dateSchema);
+ HoodieSchema dateSchema = HoodieSchema.create(HoodieSchemaType.INT);
Review Comment:
Should this be `HoodieSchema.createDate();`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
