the-other-tim-brown commented on code in PR #17772:
URL: https://github.com/apache/hudi/pull/17772#discussion_r2672485841
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/model/HoodieFlinkRecord.java:
##########
@@ -139,9 +139,9 @@ public String getRecordKey(Schema recordSchema,
Option<BaseKeyGenerator> keyGene
}
@Override
- public String getRecordKey(Schema recordSchema, String keyFieldName) {
+ public String getRecordKey(HoodieSchema recordSchema, String keyFieldName) {
if (key == null) {
- String recordKey =
Objects.toString(RowDataAvroQueryContexts.fromAvroSchema(recordSchema).getFieldQueryContext(keyFieldName).getFieldGetter().getFieldOrNull(data));
+ String recordKey =
Objects.toString(RowDataAvroQueryContexts.fromAvroSchema(recordSchema.toAvroSchema()).getFieldQueryContext(keyFieldName).getFieldGetter().getFieldOrNull(data));
Review Comment:
We'll take this on in https://github.com/apache/hudi/pull/17739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
