voonhous commented on code in PR #17659:
URL: https://github.com/apache/hudi/pull/17659#discussion_r2671506796
##########
hudi-aws/src/main/java/org/apache/hudi/aws/sync/AWSGlueCatalogSyncClient.java:
##########
@@ -476,10 +476,10 @@ private String getTableDoc() {
@Override
public List<FieldSchema> getStorageFieldSchemas() {
try {
- return tableSchemaResolver.getTableAvroSchema(true)
+ return tableSchemaResolver.getTableSchema(true)
.getFields()
.stream()
- .map(f -> new FieldSchema(f.name(), f.schema().getType().getName(),
f.doc()))
+ .map(f -> new FieldSchema(f.name(),
f.schema().getType().toAvroType().getName(), f.doc()))
Review Comment:
Yeap, will remove.
##########
hudi-common/src/main/java/org/apache/hudi/index/secondary/SecondaryIndexManager.java:
##########
@@ -82,16 +82,16 @@ public void create(
Map<String, String> options) {
Option<List<HoodieSecondaryIndex>> secondaryIndexes =
SecondaryIndexUtils.getSecondaryIndexes(metaClient);
Set<String> colNames = columns.keySet();
- Schema avroSchema;
+ HoodieSchema schema;
try {
- avroSchema = new
TableSchemaResolver(metaClient).getTableAvroSchema(false);
+ schema = new TableSchemaResolver(metaClient).getTableSchema(false);
} catch (Exception e) {
throw new HoodieSecondaryIndexException(
"Failed to get table avro schema: " +
metaClient.getTableConfig().getTableName());
}
for (String col : colNames) {
- if (avroSchema.getField(col) == null) {
+ if (schema.getField(col) == null) {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
