voonhous commented on code in PR #17659:
URL: https://github.com/apache/hudi/pull/17659#discussion_r2671513091
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/table/TestTableSchemaResolver.java:
##########
@@ -113,42 +112,6 @@ void testRecreateSchemaWhenDropPartitionColumns() {
}
}
- @Test
- void testGetTableSchema() throws Exception {
Review Comment:
This is a compatibility test comparing between the types that return
`Avro.Schema` and `HoodieSchema`, ensuring that they return the equivalent
results.
Since we are changing all methods to return `HoodieSchema`, there is no
`Avro.Schema` to compare against, hence test is removed as there is nothing to
compare against.
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/TestHoodieSparkSqlWriterWithTestFormat.scala:
##########
@@ -685,7 +685,7 @@ class TestHoodieSparkSqlWriterWithTestFormat extends
HoodieSparkWriterTestBase {
private def fetchActualSchema(): HoodieSchema = {
val tableMetaClient = createMetaClient(spark, tempBasePath)
- new TableSchemaResolver(tableMetaClient).getTableSchema()
+ new TableSchemaResolver(tableMetaClient).getTableSchema(false)
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
