the-other-tim-brown commented on code in PR #17659:
URL: https://github.com/apache/hudi/pull/17659#discussion_r2672550614
##########
hudi-aws/src/main/java/org/apache/hudi/aws/sync/AWSGlueCatalogSyncClient.java:
##########
@@ -476,10 +476,10 @@ private String getTableDoc() {
@Override
public List<FieldSchema> getStorageFieldSchemas() {
try {
- return tableSchemaResolver.getTableAvroSchema(true)
+ return tableSchemaResolver.getTableSchema(true)
.getFields()
.stream()
- .map(f -> new FieldSchema(f.name(), f.schema().getType().getName(),
f.doc()))
+ .map(f -> new FieldSchema(f.name(), f.schema().getType().name(),
f.doc()))
Review Comment:
For fields that are logical types in avro, we will likely be returning their
underlying data type. What impact will that have on the sync now that we would
return the logical type name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
