This is an automated email from the ASF dual-hosted git repository.

voonhous pushed a commit to tag rfc-105-pre-cleanup
in repository https://gitbox.apache.org/repos/asf/hudi.git

commit a0bb1a57b5743729c6b9ff27959a00edec95b066
Author: voon <[email protected]>
AuthorDate: Tue May 26 23:16:47 2026 +0800

    fix(trino): add junit-platform-launcher as explicit test dep to fix surefire
    
    The previous junit-platform pin in dependencyManagement was necessary but
    not sufficient. dependencyManagement only takes effect when something
    declares the dep, and the project test classpath never declared
    junit-platform-launcher -- surefire fell back to its bundled (older) copy.
    When the bundled launcher's DefaultDiscoveryRequest does not override
    getOutputDirectoryCreator, jupiter-engine 5.14.1 throws on test discovery.
    
    Declare junit-platform-launcher explicitly at test scope so the version
    pin in dependencyManagement (1.14.1) lands on the test classpath and
    surefire prefers it over the bundled copy.
---
 hudi-trino-plugin/pom.xml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/hudi-trino-plugin/pom.xml b/hudi-trino-plugin/pom.xml
index fd281d96ff30..708daebc0188 100644
--- a/hudi-trino-plugin/pom.xml
+++ b/hudi-trino-plugin/pom.xml
@@ -476,6 +476,16 @@
             <artifactId>junit-jupiter-engine</artifactId>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <!-- Surefire bundles its own junit-platform-launcher; if it 
predates platform 1.11
+                 the bundled DefaultDiscoveryRequest does not override 
getOutputDirectoryCreator
+                 and the jupiter-engine 5.14 / platform-engine 1.14 pair 
throws on discovery.
+                 Declaring the launcher explicitly puts 1.14.1 on the project 
classpath, which
+                 surefire prefers over its bundled copy. -->
+            <groupId>org.junit.platform</groupId>
+            <artifactId>junit-platform-launcher</artifactId>
+            <scope>test</scope>
+        </dependency>
         <dependency>
             <groupId>org.junit.jupiter</groupId>
             <artifactId>junit-jupiter-params</artifactId>

Reply via email to