This is an automated email from the ASF dual-hosted git repository. voonhous pushed a commit to tag rfc-105-pre-cleanup in repository https://gitbox.apache.org/repos/asf/hudi.git
commit fed1d02718e272cb0cedb4f16c9139c061ea1262 Author: voon <[email protected]> AuthorDate: Wed May 27 20:23:06 2026 +0800 docs(trino): update SUPPORTS_LIMIT_PUSHDOWN comment after applyLimit lands applyLimit is now implemented but the capability flag still stays false because BaseConnectorTest.testLimitPushdown requires limitGuaranteed=true (Output->TableScan with no Limit) and a multi-split connector cannot promise that. Reword the inline comment so it captures the real constraint instead of pointing at a TODO that no longer applies. --- .../src/test/java/io/trino/plugin/hudi/TestHudiConnectorTest.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hudi-trino-plugin/src/test/java/io/trino/plugin/hudi/TestHudiConnectorTest.java b/hudi-trino-plugin/src/test/java/io/trino/plugin/hudi/TestHudiConnectorTest.java index d1a1460a2ed3..acb85a2fe25f 100644 --- a/hudi-trino-plugin/src/test/java/io/trino/plugin/hudi/TestHudiConnectorTest.java +++ b/hudi-trino-plugin/src/test/java/io/trino/plugin/hudi/TestHudiConnectorTest.java @@ -49,7 +49,10 @@ public class TestHudiConnectorTest SUPPORTS_DELETE, SUPPORTS_DEREFERENCE_PUSHDOWN, SUPPORTS_INSERT, - // TODO: implement LIMIT pushdown in HudiMetadata.applyLimit and flip this on. + // HudiMetadata.applyLimit returns limitGuaranteed=false (multi-split connector + // cannot bound total rows across workers). BaseConnectorTest.testLimitPushdown + // requires Output->TableScan with no Limit node, which needs guaranteed=true. + // Stays off, matching Iceberg / Delta Lake / Hive. SUPPORTS_LIMIT_PUSHDOWN, SUPPORTS_MERGE, SUPPORTS_RENAME_COLUMN,
